Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddeclient and ddeserver demos import error #2290

Merged
merged 5 commits into from
Oct 26, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jun 5, 2024

Fixes #1258

@Avasam Avasam force-pushed the ddeserver-demo-import-error branch from 887ead8 to d9159a8 Compare October 4, 2024 21:46
@Avasam Avasam requested a review from mhammond October 18, 2024 18:40
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is worth a changelog entry tbh

@Avasam
Copy link
Collaborator Author

Avasam commented Oct 26, 2024

not sure this is worth a changelog entry tbh

My thought process is: Demos are public-facing. And it's a fix for an issue that was raised, so it visibly affects at least a user. It's probably similar to fixing documentation.

I'll keep it since you're not requesting to remove the entry. But it's always up to you if you decide to remove it later. (note that there's already mentions of fixing demos in previous changelog entries)

@Avasam Avasam merged commit 14df895 into mhammond:main Oct 26, 2024
6 of 15 checks passed
@Avasam Avasam deleted the ddeserver-demo-import-error branch October 26, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import "dde" on pywin 224
2 participants